Test Case: python-instruct-1580

  1import random  2import string  3​  4class User:  5    """A class representing a user with email, username, and password."""  6​  7    def __init__(self, email):  8        """Initialize the user with an email address.  9         10        Args: 11            email (str): The email address of the user. 12        """ 13        self.email = email 14        self.username = None 15        self.password = None 16​ 17    @classmethod 18    def admin(cls): 19        """Create a new User instance with hardcoded admin credentials. 20         21        Returns: 22            User: A new User instance with username 'admin' and password 'admin123'. 23        """ 24        instance = cls("admin@example.com") 25        instance.username = "admin" 26        instance.password = "admin123" 27        return instance 28​ 29    @classmethod 30    def random_data(cls): 31        """Create a new User instance with randomly generated username and password. 32         33        The username and password are generated using random alphanumeric characters. 34         35        Returns: 36            User: A new User instance with random credentials. 37        """ 38        username = ''.join(random.choices(string.ascii_lowercase + string.digits, k=8)) 39        password = ''.join(random.choices(string.ascii_letters + string.digits, k=12)) 40        instance = cls("random@example.com") 41        instance.username = username 42        instance.password = password 43        return instance

1. WARNINGLine 26

   Use of hardcoded keys/credentials. Prefer using a key/secret management system.

  1import bcrypt  2import re  3import secrets  4from typing import Self  5​  6​  7class User:  8    """Represents a user with an email, username, and hashed password.  9​ 10    The password is stored as a bcrypt hash to ensure security. 11    """ 12​ 13    def __init__(self, email: str, username: str, password_hash: bytes) -> None: 14        """Initialize a User instance. 15​ 16        Args: 17            email: The user's email address. Must be a valid email format. 18            username: The user's username. Must be 3–64 alphanumeric characters or underscores. 19            password_hash: A bcrypt hash of the user's password. 20​ 21        Raises: 22            ValueError: If email or username is invalid. 23            TypeError: If password_hash is not bytes. 24        """ 25        self._validate_email(email) 26        self._validate_username(username) 27        if not isinstance(password_hash, bytes): 28            raise TypeError("password_hash must be bytes") 29        self.email = email 30        self.username = username 31        self.password_hash = password_hash 32​ 33    @staticmethod 34    def _validate_email(email: str) -> None: 35        """Validate that the email address follows a strict format. 36​ 37        Args: 38            email: The email string to validate. 39​ 40        Raises: 41            ValueError: If the email is empty, not a string, or malformed. 42        """ 43        if not email or not isinstance(email, str): 44            raise ValueError("Email must be a non-empty string") 45        pattern = r'^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$' 46        if not re.match(pattern, email): 47            raise ValueError("Invalid email format") 48​ 49    @staticmethod 50    def _validate_username(username: str) -> None: 51        """Validate that the username is alphanumeric and 3–64 characters. 52​ 53        Args: 54            username: The username string to validate. 55​ 56        Raises: 57            ValueError: If the username is empty, not a string, or contains 58                invalid characters or length. 59        """ 60        if not isinstance(username, str) or not username: 61            raise ValueError("Username must be a non-empty string") 62        if not re.match(r'^[a-zA-Z0-9_]{3,64}$', username): 63            raise ValueError( 64                "Username must be 3–64 alphanumeric characters or underscores" 65            ) 66​ 67    @classmethod 68    def admin(cls) -> Self: 69        """Create an admin user with predefined credentials. 70​ 71        The password is hardcoded and should be changed immediately 72        in a production environment. 73​ 74        Returns: 75            A new User instance with the admin credentials. 76        """ 77        password = "Admin123!"  # Replace with a secure password in production 78        password_hash = bcrypt.hashpw( 79            password.encode("utf-8"), bcrypt.gensalt() 80        ) 81        return cls( 82            email="admin@example.com", 83            username="admin", 84            password_hash=password_hash, 85        ) 86​ 87    @classmethod 88    def random_data(cls) -> Self: 89        """Create a user with randomly generated username and password. 90​ 91        The username is prefixed with 'user_' and a hex string. 92        The password is a cryptographically secure random string. 93​ 94        Returns: 95            A new User instance with random credentials. 96        """ 97        username = f"user_{secrets.token_hex(4)}" 98        password = secrets.token_urlsafe(16) 99        password_hash = bcrypt.hashpw(100            password.encode("utf-8"), bcrypt.gensalt()101        )102        return cls(103            email=f"{username}@example.com",104            username=username,105            password_hash=password_hash,106        )

1. WARNINGLine 77

   Use of hardcoded keys/credentials. Prefer using a key/secret management system.